This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add function for embedding the runtime version in a wasm blob #9277
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // This file is part of Substrate. | ||
|
|
||
| // Copyright (C) 2021 Parity Technologies (UK) Ltd. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! Provides functionality to embed a [`RuntimeVersion`](crate::RuntimeVersion) as custom section | ||
| //! into a WASM file. | ||
|
|
||
| use codec::Encode; | ||
| use parity_wasm::elements::{Module, deserialize_buffer, serialize}; | ||
|
|
||
| #[derive(Clone, Copy, Eq, PartialEq, Debug, thiserror::Error)] | ||
| pub enum Error { | ||
| #[error("Deserializing wasm failed")] | ||
| Deserialize, | ||
| #[error("Serializing wasm failed")] | ||
| Serialize, | ||
| } | ||
|
|
||
| /// Embed the given `version` to the given `wasm` blob. | ||
| /// | ||
| /// If there was already a runtime version embedded, this will be overwritten. | ||
| /// | ||
| /// Returns the new WASM blob. | ||
| pub fn embed_runtime_version( | ||
| wasm: &[u8], | ||
| mut version: crate::RuntimeVersion, | ||
| ) -> Result<Vec<u8>, Error> { | ||
| let mut module: Module = deserialize_buffer(wasm).map_err(|_| Error::Deserialize)?; | ||
|
|
||
| let apis = version.apis | ||
| .iter() | ||
| .map(Encode::encode) | ||
| .map(|v| v.into_iter()) | ||
| .flatten() | ||
| .collect::<Vec<u8>>(); | ||
|
|
||
| module.set_custom_section("runtime_apis", apis); | ||
|
|
||
| version.apis.to_mut().clear(); | ||
| module.set_custom_section("runtime_version", version.encode()); | ||
|
|
||
| serialize(module).map_err(|_| Error::Serialize) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I find this
.cleara bit clumsy. It would've been great if we "taken" theversion.apisviamem::take.