This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix buggy string comparison in OCW pallet example#8602
Merged
bkchr merged 1 commit intoparitytech:masterfrom Apr 12, 2021
Merged
Fix buggy string comparison in OCW pallet example#8602bkchr merged 1 commit intoparitytech:masterfrom
bkchr merged 1 commit intoparitytech:masterfrom
Conversation
bkchr
approved these changes
Apr 12, 2021
bkchr
added
A2-insubstantial
tomusdrw
approved these changes
Apr 12, 2021
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also made the code a bit more idiomatic by leveraging the use of
?.The problem with the previous algorithm was that the iterator for
"USD"is not reset back to the starting position in subsequent iterations of thefindfunction, i.e. imagine we have the following JSON:{ "UAH": 214, "USD": 342 }The original code would first see that the "UAH" string matches the first character (
'U'), and it would continue to match the next one (matching'A'with'S'), but doesn't find a match, then thecharsiterator will stay at the'S'position when looping to the next key. This means it will erroneously refuse to match against the second key ("USD") in this example.Though it's impossible to get a JSON that has more than 1 entry in the OCW example, I feel like it's best to get this algorithm correct, because downstream Substrate pallet developers may copy and paste this code into their pallet and may encounter this bug if they are not careful.