This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
gavofyork
approved these changes
Oct 16, 2018
sorpaas
reviewed
Oct 18, 2018
| // => use iter to enumerate all keys AND lookup each | ||
| // key using get_with | ||
| trie.get_with(&key, &mut *self.proof_recorder) | ||
| .map(|x| x.map(|val| val.to_vec()))?; |
Contributor
There was a problem hiding this comment.
Why do we need this map? It looks like the resulting vec is immediately dropped?
Contributor
Author
There was a problem hiding this comment.
Yep, thanks. Could you please remove it in your PR? :)
sorpaas
added a commit
that referenced
this pull request
Oct 18, 2018
gavofyork
pushed a commit
that referenced
this pull request
Oct 18, 2018
* Implement a non generic version of child delta trie * Use delta_trie_root in state_machine * Expand InMemory backend to support multi-storage * Create Consolidate trait * Fix all crate compile and remove unused OverlayedChanges::drain * Implement child storage root support and overlay changes * Add child storage reader * Add child storage writer * Implement child storage cleaning * Fix light backend compile * Add all required ext functions for wasm executor * Add ext def to io * Add all io functions * Fix nostd compile * Add simple test * Remove unnecessary vec copy in child_storage_root_transaction * Use values_mut/for_each to make it shorter * Use extend to shorter a for loop * Move record_all_keys to trie so it's easier to generic them later * space -> tab * Remove to_owned in debug format * Clean out all to_owned * Break debug_trace to multiple lines * Remove 0.. * UserError copy/paste typo * Replace Vec::from_raw_parts by slice::from_raw_parts * Use iter::empty() * Wrap some long lines * Wrap a missing line * Remove unnecessary map #856 (comment) * Call ext_free after from_raw_parts * Fix tests in other crates
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.26 to 0.3.27. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.26...0.3.27) --- updated-dependencies: - dependency-name: futures dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Wilson <james@jsdw.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
max_digest_intervalchanges tries for lastmax_digest_intervalblocks => they're never prunedmax_digest_intervalranges)max_digest_intervalrange blocks (so probably we need to limit themax_digest_intervalto avoid large db transactions - left a TODO on this)