This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactor NotifsHandler::poll #8422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
Contributor
Author
|
Reduced polling rate seems to work:
|
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Refactor a bit NotifsHandler::poll * Avoid some spurious wake-ups
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
* Refactor a bit NotifsHandler::poll * Avoid some spurious wake-ups
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
* Refactor a bit NotifsHandler::poll * Avoid some spurious wake-ups
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better version of #8405 (and #8410)
Now that the legacy substream is gone, this cleans up the hack introduced in #7594
This PR does two things:
Poll::Ready, and not the other way around.cx.waker().wake_by_ref()and by only callingSink::poll_ready()on the substream only if there is actually something to send in the channel, and not all the time.