Remove Offence delay

[Lohann]

Description

An offence can and should be immediately processed by the staking pallet.
Fixes #8343

Checklist:

• Remove can_report API from OnOffenceHandler
• Remove DeferredOffences storage from offences pallet
• Implement the storage migration logic
• Update unit tests
• Update benchmarks
• Test if all deferred offences has been submited after on_runtime_upgrade hook

Context

Due to some technical circumstances the Offence delay has been introduced here #4517
There's a good discussion about how to properly migrate storages here: #8243

polkadot companion: paritytech/polkadot#2966

[Lohann]

One question, the only safe and deterministic way to remove the DeferredOffences storage is if the OnOffenceHandler::on_offence always succeed. Otherwise how do we guarantee that all deferred offences has been emitted?

[kianenigma]

One question, the only safe and determinist way to remove the DeferredOffences storage is if the OnOffenceHandler::on_offence always succeed. Otherwise how do we guarantee that all deferred offences has been emitted?

Sorry, don't get what you mean here?

[Lohann]

All unit tests passed 🎉

The only thing that is missing is create a test that verifies if all offences has been resubmitted after on_runtime_upgrade

[kianenigma]

All unit tests passed 🎉

The only thing that is missing is create a test that verifies if all offences has been resubmitted after on_runtime_upgrade

Yeah, while generally it is a rare scenario, worth having a test for it.

[Lohann]

Ok all good, but I don't have permission to add the labels and make CI happy.

[Lohann]

@thiolliere good catch, WeightSoftLimit removed 👍

[Lohann]

Now I'm working on the companion PR

[shawntabrizi]

lgtm

[Lohann]

bot merge

[ghost]

Error: Error getting organization membership: Status code: 404 Not Found
Body:
Object({
"documentation_url": String(
"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user",
),
"message": String(
"User does not exist or is not a member of the organization",
),
})

[shawntabrizi]

@Lohann will have Kian merge this when he wakes up and if he is happy

[Lohann]

@shawntabrizi sounds good! thx for your patience reviewing this PR 🙏

Btw the Companion section of CONTRIBUTING.adoc#updating-polkadot-as-well needs to be updated, using paths = ["path/to/substrate"] in ~/.cargo/config doesn't work for me (and seems deprecated too).

For create the companion PR I used diener instead, which is not documented but I've found it in the check_polkadot_companion_build.sh script.

git clone --depth 20 https://github.com/paritytech/polkadot.git
cargo install -f diener
cd polkadot
diener patch --crates-to-patch ../ --substrate --path Cargo.toml

[shawntabrizi]

paths = ["path/to/substrate"] in ~/.cargo/config doesn't work for me (and seems deprecated too).

This works for me last I tried. What did you see was the issue when you tried it?

[Lohann]

Will run again, one minute

[Lohann]

My ~/.cargo/config.toml

$ cat ~/.cargo/config.toml 
paths = ["/Users/lohannpaternocoutinhoferreira/Documents/Projects/substrate"]

Output of cargo build

warning: path override for crate `sp-trie` has altered the original list of
dependencies; the dependency on `sp-core` was either added or
modified to not match the previously resolved version

This is currently allowed but is known to produce buggy behavior with spurious
recompiles and changes to the crate graph. Path overrides unfortunately were
never intended to support this feature, so for now this message is just a
warning. In the future, however, this message will become a hard error.

To change the dependency graph via an override it's recommended to use the
`[replace]` feature of Cargo instead of the path override feature. This is
documented online at the url below for more information.

https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

error: failed to select a version for `semver-parser`.
    ... required by package `semver v0.11.0`
    ... which is depended on by `cargo_metadata v0.13.1`
    ... which is depended on by `substrate-wasm-builder v4.0.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/substrate)`
    ... which is depended on by `kusama-runtime v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot/runtime/kusama)`
    ... which is depended on by `polkadot-service v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot/node/service)`
    ... which is depended on by `polkadot v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot)`
versions that meet the requirements `=0.10.0` are: 0.10.0

all possible versions conflict with previously selected packages.

  previously selected package `semver-parser v0.10.2`
    ... which is depended on by `cargo_metadata v0.13.1`
    ... which is depended on by `substrate-wasm-builder v4.0.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/substrate)`
    ... which is depended on by `kusama-runtime v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot/runtime/kusama)`
    ... which is depended on by `polkadot-service v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot/node/service)`
    ... which is depended on by `polkadot v0.9.0 (/Users/lohannpaternocoutinhoferreira/Documents/Projects/polkadot)`

failed to select a version for `semver-parser` which could resolve this conflict

[kianenigma]

Thanks!

[kianenigma]

bot merge

[ghost]

Waiting for commit status.