This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pallet macro broke benchmarks_instance, fix by introducing benchmarks_instance_pallet
#8190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
B0-silent
coriolinus
approved these changes
Feb 24, 2021
Co-authored-by: Peter Goodspeed-Niklaus <[email protected]>
jam10o-new
pushed a commit
to jam10o-new/substrate
that referenced
this pull request
Feb 28, 2021
…rks_instance_pallet` (paritytech#8190) Co-authored-by: Peter Goodspeed-Niklaus <[email protected]>
Contributor
Author
|
@gnunicorn could we release frame-benchmarking 3.2 with this PR ? |
Contributor
|
@thiolliere the merge commit has already been released as 3.1:
|
Contributor
Author
|
damn I forgot, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently instantiable pallet define with pallet macro cannot use benchmarks_instance because it bounds
I: Instance.Instead this PR introduce a new macro:
benchmarks_instance_palletAlso this PR make use of this macro for pallet-balances. Currently the benchmark only works for the default instance of pallet balance.