This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove all code related to sentry nodes #8079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
mxinden
approved these changes
Feb 9, 2021
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me.
Contributor
|
Closes #6845 |
bkchr
approved these changes
Feb 12, 2021
romanb
approved these changes
Feb 12, 2021
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
athei
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Remove all code related to sentry nodes * More fixing
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
* Remove all code related to sentry nodes * More fixing
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
--sentryand--sentry-nodesCLI options, plus all the code that was still related to sentry nodes.The reason for this change is that we really want sentry nodes to be gone when parachains arrive on Kusama and Polkadot.
Some validators still use sentry nodes despite the deprecation. This PR adds a hard deadline.
I went for removing the code altogether instead of leaving it disabled, as the implementation isn't very large. The diff of this PR can be used to get inspiration when we want to restore sentry nodes.
polkadot companion: paritytech/polkadot#2408