This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
dvdplm
added
A2-insubstantial
Member
|
I have fixed it properly in: #8022 TLDR: The tests and some log setup were broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During work on #7780 I noticed that some of the sc-tracing tests were interfering with other tests, see comment. This is likely due to the way the logging tests in the crate spawn extra processes during the test run to assert specific output. These tests are better off as integration tests in their own crate.