Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@apopiak
Copy link
Contributor

@apopiak apopiak commented Feb 1, 2021

Make the generated AllModules and AllModuleWithSystem types public so crates depending on FRAME runtimes can access them. (Useful for e.g. testing.)

@apopiak apopiak added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 1, 2021
@apopiak apopiak requested a review from bkchr February 1, 2021 14:48
@apopiak apopiak requested review from gui1117 and kianenigma February 1, 2021 15:35
@apopiak apopiak mentioned this pull request Feb 1, 2021
2 tasks
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this has any noteworthy breakage with it, so all good.

@apopiak
Copy link
Contributor Author

apopiak commented Feb 1, 2021

bot merge

@ghost
Copy link

ghost commented Feb 1, 2021

Trying merge.

@ghost ghost merged commit 043cb0a into master Feb 1, 2021
@ghost ghost deleted the apopiak-pub-all-types branch February 1, 2021 15:55
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants