Fix UI Tests

[shawntabrizi]

This PR fix UI tests from an update in Rust Compiler.

[shawntabrizi]

hmm seems to fail again?

[kianenigma]

Maybe try running the tests with TRYBUILD=overwrite?

UPDATE: tried it myself and will push to see if works.

[bkchr]

@kianenigma please revert your changes

[kianenigma]

reverted.

[bkchr]

Ty

[TriplEight]

@shawntabrizi @bkchr I ran this on the fresh paritytech/ci-linux:staging and have to tell that these tests are successful. With lots of warnings, though. I can push that image to the prod.

[TriplEight]

Also, I've noticed that Compiling substrate-browser-utils v0.8.0 takes ages, maybe even hangs somewhere in the process.

[TriplEight]

yeah, unfortunately Compiling substrate-browser-utils v0.8.0 seems to hang forever, tried with
rustc 1.50.0-nightly (d32c320d7 2020-12-10) and rustc 1.50.0-nightly (803c60218 2020-12-13). The command is cargo +nightly build --manifest-path=bin/node/cli/Cargo.toml --no-default-features --features browser --target=wasm32-unknown-unknown -Z features=itarget.

@bkchr 's guess that it's rust-lang/rust#75992 regression

[gui1117]

but which version of rust are you using to have those outputs ? CI still seems to expect the old output

[TriplEight]

I'm reproducing it with a new staging image and rustc 1.50.0-nightly (b32e6e6ac 2020-12-16)
It still hangs here:

   Compiling substrate-browser-utils v0.8.0 (/builds/utils/browser)
    Building [=======================> ] 647/652: node-runtime(build)

Does it maybe make sense to remove this test/feature until fixed in order to update nightly?

[bkchr]

@TriplEight could you find out when it still worked?

[TriplEight]

I went through

production:
rustc 1.50.0-nightly (825637983 2020-11-18) # image docker.io/paritytech/ci-linux:production
rustc 1.50.0-nightly (eb4fc71dc 2020-12-17) # docker.io/paritytech/ci-linux:staging
2020-12-01
2020-11-25 (24)
2020-11-25 (21)
2020-11-19
2020-11-18

docker.io/paritytech/ci-linux:d0f2b553-20201118
docker.io/paritytech/ci-linux:3ec7097e-20201117
docker.io/paritytech/ci-linux:3ec7097e-20201116
docker.io/paritytech/ci-linux:4cc65dc0-20201102
docker.io/paritytech/ci-linux:974ba3ac-20201001

And it seems the problem is not exactly clear. On my machine all of these nightlies have shown the same behavior:

cargo +nightly build --manifest-path=bin/node/cli/Cargo.toml --no-default-features --features browser --target=wasm32-unknown-unknown -Z features=itarget

freezes on

   Compiling substrate-browser-utils v0.8.0 (/builds/utils/browser)
    Building [=======================> ] 647/652: node-runtime(build)

But CI however, runs this test on production image quite fast.

I will try it on the CI machines later.

[TriplEight]

Just got Finished dev [unoptimized + debuginfo] target(s) in 3m 57s
Running in this morning's docker.io/paritytech/ci-linux:staging on CI machine.

[TriplEight]

And what actually breaks when staging image is tested against master substrate is:

# cargo test --workspace --locked --release --verbose --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml

...
running 1 test
    Checking frame-support-test-tests v0.0.0 (/builds/target/tests/frame-support-test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.44s


test tests/derive_no_bound_ui/clone.rs ... mismatch

EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0277]: the trait bound `<T as Config>::C: std::clone::Clone` is not satisfied
 --> $DIR/clone.rs:7:2
  |
7 |     c: T::C,
  |     ^ the trait `std::clone::Clone` is not implemented for `<T as Config>::C`
  |
  = note: required by `std::clone::Clone::clone`
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0277]: the trait bound `<T as Config>::C: Clone` is not satisfied
 --> $DIR/clone.rs:7:2
  |
7 |     c: T::C,
  |     ^ the trait `Clone` is not implemented for `<T as Config>::C`
  |
  = note: required by `clone`
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite

test tests/derive_no_bound_ui/debug.rs ... ok
test tests/derive_no_bound_ui/eq.rs ... mismatch

EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0277]: can't compare `Foo<T>` with `Foo<T>`
   --> $DIR/eq.rs:6:8
    |
6   | struct Foo<T: Config> {
    |        ^^^ no implementation for `Foo<T> == Foo<T>`
    |
    = help: the trait `std::cmp::PartialEq` is not implemented for `Foo<T>`
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0277]: can't compare `Foo<T>` with `Foo<T>`
   --> $DIR/eq.rs:6:8
    |
6   | struct Foo<T: Config> {
    |        ^^^ no implementation for `Foo<T> == Foo<T>`
    |
    = help: the trait `PartialEq` is not implemented for `Foo<T>`
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite

test tests/derive_no_bound_ui/partial_eq.rs ... ok


test derive_no_bound_ui ... FAILED

failures:

---- derive_no_bound_ui stdout ----
thread 'derive_no_bound_ui' panicked at '2 of 4 tests failed', /usr/local/cargo/git/checkouts/trybuild-d179a8e37194da24/0eaad05/src/run.rs:61:13
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483
   1: std::panicking::begin_panic_fmt
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:437
   2: <trybuild::TestCases as core::ops::drop::Drop>::drop
   3: core::ops::function::FnOnce::call_once
   4: core::ops::function::FnOnce::call_once
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/ops/function.rs:227
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    derive_no_bound_ui

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p frame-support-test --test derive_no_bound_ui'

[TriplEight]

feel free to make another issue from it ^

[TriplEight]

Just realized it was about what this PR fixes ^, testing with this branch

[TriplEight]

I've pushed the CI image with the latest nightly to production and CI is happy
.