Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix notifications sometimes not being sent #7594

Merged
2 commits merged into from
Nov 25, 2020
Merged

Fix notifications sometimes not being sent #7594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb1e3cd
Fix notifications sometimes not being sent
tomaka Nov 24, 2020
ab31856
Add comment
tomaka Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/network/src/protocol/generic_proto/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,7 @@ impl ProtocolsHandler for NotifsHandler {
if let Some(pos) = self.out_protocols.iter().position(|(n, _)| *n == protocol_name) {
if let Some(substream) = out_substreams[pos].as_mut() {
let _ = substream.start_send_unpin(message);
cx.waker().wake_by_ref();

@mxinden mxinden Nov 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind documenting that this wake up is used to force another call to NotifsHandler::poll and thus to flush the corresponding substreams?

In addition I would suggest documenting that this is temporary and removed with #7374.

continue 'poll_notifs_sink;
}

Expand Down