Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

sc-cli: replace bip39 with tiny-bip39 #7551

Merged
bkchr merged 1 commit into from
Nov 18, 2020
Merged

sc-cli: replace bip39 with tiny-bip39 #7551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 13 additions & 86 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ libp2p = "0.30.1"
parity-scale-codec = "1.3.0"
hex = "0.4.2"
rand = "0.7.3"
bip39 = "0.6.0-beta.1"
tiny-bip39 = "0.8.0"
Copy link
Member

@bkchr bkchr Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change is the only required one, it means we don't require this dependency?

Copy link
Contributor Author

@koushiro koushiro Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, actually the library name of tiny-bip39 is bip39 :P, so we don't need to modify the rust code.

Copy link
Contributor

@dvdplm dvdplm Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: tiny-bip39 is a fork of bip39 by @maciejhirsz that includes some good cleanup, including some secret-zeroing that would be good to have. The original crate is maintained but slow moving. There are signs of a bip39 1.0 coming at some point.
As @koushiro points out, the two crates are API compatible, so switching back should be fairly easy.

serde_json = "1.0.41"
sc-keystore = { version = "2.0.0", path = "../keystore" }
sp-panic-handler = { version = "2.0.0", path = "../../primitives/panic-handler" }
Expand Down