This repository was archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Rework contracts_call RPC #7468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to use this type in the contracts RPC.
athei
added
A0-please_review
ascjones
reviewed
Oct 30, 2020
bkchr
approved these changes
Oct 30, 2020
jacogr
approved these changes
Oct 30, 2020
Member
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
contracts_callRPC so that more information is returned. The following changes are made:gas_consumedis returned in any case and not only on success.DispatchErroris returned instead of nothing. Can be used by the UI to pre-run a contract call and show the user what is going wrong.debug_messageis introduced that can be used to return dynamic information. In the future, the plan is to use the field to allow outputting more precise error messages and to support println debugging. Those messages will only be collected when called by RPC and will introduce no overhead when executed as transaction. This is currently unused and will return an empty string.This will need changes in polkadot.js API @jacogr
Also I needed to derive
DeserializeforDispatchErrorbecause that is a requirement to use it in an RPC even though it is only used as a result.