This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
sc-network: expose add_to_priority_group and `remove_from_priority_…
#7247
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c5b6ad1
sc-network: expose `add_to_priority_group` and `remove_from_priority_…
ordian f999356
sc-network: fix a typo
ordian d0f0565
Merge branch 'master' into ao-network-expose-incremental-priority-gro…
ordian f089aaf
Merge branch 'master' into ao-network-expose-incremental-priority-gro…
ordian c751e29
Update client/network/src/service.rs
ordian 3ea90f2
s/parse_multiaddr/split_multiaddr_and_peer_id/g
ordian 98bbafa
Merge branch 'ao-network-expose-incremental-priority-group-updates' o…
ordian b1c28b2
sc-network: mark new functions as async and add comments
ordian 3babad9
Apply suggestions from code review
ordian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaring this method as
asyncwould grant us a greater implementation flexibility in the future, e.g. a bounded channel betweenNetworkServiceandNetworkWorker.@tomaka what do you think of requiring all new methods on
NetworkServiceto be able to yield?@ordian Are you able to
awaitthis method within Polkadot?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, awaiting is fine, but would we need to change all three methods then (set_, add_, remove_)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b1c28b2.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 As eventually it'd be nice if the queue from the network service to the worker was bounded as well.