Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Time-delay proxies #6770

Merged
38 commits merged into from
Aug 23, 2020
Merged

Time-delay proxies #6770

38 commits merged into from
Aug 23, 2020

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Jul 30, 2020

This allows a proxy to be set so that the delegated account is required to announce (a hash of) their action some period before they can actually do it.

During this period, the proxied account can cancel the announcement and veto the action.

Combined with wallet software that alerts when these announcements are made, it should allow hot keys or warm keys to be used practically on relatively large sums of funds.

TODO:

  • Tests
  • Benchmarks
  • Weights
  • Docs
  • Migration
  • Polkadot companion

polkadot companion: paritytech/polkadot#1520

cc @jacogr

@gavofyork gavofyork added A3-in_progress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Jul 30, 2020
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 30, 2020
@gavofyork gavofyork added the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Aug 3, 2020
frame/proxy/src/lib.rs Outdated Show resolved Hide resolved
* update bechmarks to parameterize announcements

* remove announcement param from proxy

* Update pallet_proxy.rs

* Update weights
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavofyork gavofyork added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. A7-needspolkadotpr D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Aug 21, 2020
@gavofyork
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Aug 23, 2020

Missing process info; check that the PR belongs to a project column.

Merge can be attempted if:

  • The PR has approval from two core-devs (or one if the PR is labelled insubstantial).
  • The PR is attached to a project column and has approval from the project owner.
  • The PR has approval from a member of substrateteamleads.

@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A8-mergeoncegreen labels Aug 23, 2020
@gavofyork
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Aug 23, 2020

Waiting for commit status.

@apopiak
Copy link
Contributor

apopiak commented Nov 20, 2020

Warning: This migration is missing a storage guard and will thus be executed more than once if included in more than one runtime upgrade.
Use the extracted migration from #7205 in combination with a storage guard if running this migration.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants