This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[WIP] Tracing events / refactor proxy / state traces #6658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from wasm traces.
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
remove proxied_spans list
mattrutherford
added
the
A3-in_progress
github-actions
bot
added
A0-please_review
mattrutherford
added
A3-in_progress
switch to tracing-core in client check target for wasm spans
Contributor
Author
|
Closing this in favour of splitting the PR to get some changes done sooner |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR that comprises 3 efforts:
In order to test this PR I have merged in changes from #6401 into this branch.
I had also experimented with moving some functionality from client into primitives to allow proxy direct access to span store, but it's not feasible for multiple reasons.
Using this method to generate traces from wasm (tracing Events) has added around 500-600ns overhead (on development machine) compared to current. This is unacceptable overhead IMO and needs resolving. Switching to use channels for span / event processing does not apparently make any difference.
TODO: