Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gavofyork
Copy link
Member

@gavofyork gavofyork commented Aug 21, 2018

  • One extra log from previous PR's grumble
  • Kill spurious identification of consensus errors (when both wasm & native return an error)

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Aug 21, 2018
@gavofyork gavofyork requested review from arkpar and rphmeier August 21, 2018 08:23
}
Err(_) => RuntimePreproc::InvalidCode,
Err(_) => {
trace!(target: "executor", "Invalid code presented to executor");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's useful to print contents of Err

@pepyakin pepyakin added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 21, 2018
@gavofyork gavofyork merged commit 020dab3 into master Aug 21, 2018
@gavofyork gavofyork deleted the gav-fixes branch August 21, 2018 10:19
dvdplm added a commit that referenced this pull request Aug 27, 2018
…and-rlpcodec

* master:
  Contract signatures checking (#478)
  extrinsic-pool: use retain() (#613)
  rename Polkadot to Substrate in the license header via following four commands (#614)
  typo fixes (#608)
  RPC: Block number to block hash (#584)
  Minor fixes for nightly 2018-08-18 (#600)
  Time-based transaction banning (#594) (#602)
  cargo --force to allow CI to build. (#599)
  Fix logging (#587)
  Fix runtime version cache (#586)
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
…ritytech#598)

* Update Substrate after repository reorganisation

* Switch back to polkadot-master

* Bump `bitvec` and `parity-scale-codec` (paritytech#591)

Also bump other dependencies, but respect semver on them.
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
* Don't hash constant values; only their types

* Fix a test

* cargo fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants