Adds export-state subcommand
#5842
Conversation
bkchr
added
A0-please_review
|
|
||
| // Remove all default child storage roots from the top storage and collect the child storage | ||
| // pairs. | ||
| while let Some(pos) = top_storage |
There was a problem hiding this comment.
@cheme it would be nice if you could take a look here, if I have done this child value collection correctly.
|
Looks good, except it loads all of the state into memory. This is fine for now, but might cause problems with bigger chains in the future. |
Yeah, the whole operation isn't that nice, but as this is only some sort of debug command. I thought that we can live with the high memory load. ;) |
| Ok::<_, Error>(()) | ||
| })?; | ||
|
|
||
| children_default.insert(key.0, StorageChild { child_info, data: pairs }); |
There was a problem hiding this comment.
Here we should insert with key (without prefix), children_default works on unprefixed key.
If only use at
substrate/client/db/src/lib.rs
Line 637 in eb259b2
There was a problem hiding this comment.
Ok I m stoopid, key was redefined with the unprefixed one so it is the unprefixed one, so please forget previous comment.
Algo looks correct to 👍
| @@ -148,6 +148,9 @@ pub mod well_known_keys { | |||
| /// Prefix of child storage keys. | |||
| pub const CHILD_STORAGE_KEY_PREFIX: &'static [u8] = b":child_storage:"; | |||
|
|
|||
| /// Prefix of the default child storage keys in the top trie. | |||
| pub const DEFAULT_CHILD_STORAGE_KEY_PREFIX: &'static [u8] = b":child_storage:default:"; | |||
There was a problem hiding this comment.
Ideally this should not be made public, we would use
let (type, key) = ChildType::from_prefixed_key(prefixed_key);
assert!(type == ChildType::Default);
client/service/src/chain_ops.rs
Outdated
| ); | ||
| let child_info = ChildInfo::new_default(&key.0); | ||
|
|
||
| let keys = self.client.child_storage_keys(&block, &child_info, &key)?; |
There was a problem hiding this comment.
Here third parameter should be empty prefix not key.
client/service/src/chain_ops.rs
Outdated
| ); | ||
| let child_info = ChildInfo::new_default(&key.0); | ||
|
|
||
| let keys = self.client.child_storage_keys(&block, &child_info, &key)?; |
| use structopt::StructOpt; | ||
|
|
||
| /// The `check-block` command used to validate blocks. | ||
| #[derive(Debug, StructOpt, Clone)] | ||
| pub struct CheckBlockCmd { | ||
| /// Block hash or number | ||
| #[structopt(value_name = "HASH or NUMBER")] | ||
| pub input: String, | ||
| pub input: BlockNumberOrHash, |
| 2 + pos, | ||
| )) | ||
| } else { | ||
| Ok(Self(block_number.into())) |
There was a problem hiding this comment.
It would be probably handy if we had a try_into for this
|
Nice. Where can I find this "extra tool that replaces the corresponding keys and makes the chain spec usable as new a new genesis" ? I always wants a feature to fork a live network and do some experiments on them. Super useful when working with ethereum. |
|
This does not exist yet, I will work on this in the next time. |
|
@bkchr I use |
|
No, you will need to remove the epoch related storage keys from the exported genesis config to make babe work. |
This adds a new sub-command
export-state. This sub-command can be used to export the state of a running chain as a chain spec. This is useful for testing runtime upgrades before distributing them on a live chain.It basically collects all the key value pairs at a given block and overwrites the genesis storage values with the collected ones. The build chain-spec will not work right away, because
Babewill complain about unexpected epoch changes and the authority set will contain authorities for which the user doesn't have the key. This will be solved by an extra tool that replaces the corresponding keys and makes the chain spec usable as new a new genesis.