Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 14, 2020

Calling NetworkService::event_stream now requires passing a name that helps identify it in the Prometheus metrics.

polkadot companion: paritytech/polkadot#995

@tomaka tomaka added A0-please_review Pull request needs code review. B2-breaksapi labels Apr 14, 2020
@tomaka tomaka requested a review from mxinden April 14, 2020 10:13
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkchr bkchr merged commit 0132d52 into master Apr 14, 2020
@bkchr bkchr deleted the tka-channel-names branch April 14, 2020 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants