This repository was archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: sentry favorite peers #5484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-in_progress
Contributor
Author
|
Implemented properly in #5520. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure sentry nodes are treated as reserved nodes from peer set (i.e. we try to maintain connections to sentry nodes);
Treat sentry and reserved nodes preferably in GRANDPA gossip validator (i.e. never restrict sending any vote data to them);
The approach in this PR is just a hacky solution quickly done to figure out if this would fix the issue. We want to expose the information about a peer being a reserved/sentry node to GRANDPA gossip validator in a more generic way, so that this can also be used by other protocols (will also be useful in Polkadot).