Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Increase limit on light client response size #5461

Merged
gavofyork merged 3 commits into from
Mar 31, 2020
Merged

Increase limit on light client response size #5461

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ab4d4
Increase limit on light client response size
tomaka Mar 30, 2020
55993d9
Address review
tomaka Mar 31, 2020
78ac81c
Merge remote-tracking branch 'upstream/master' into inc-light-client-…
tomaka Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/network/src/protocol/light_client_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,13 @@ pub struct Config {
impl Config {
/// Create a fresh configuration with the following options:
///
/// - max. data size = 1 MiB
/// - max. data size = 64 MiB
/// - max. pending requests = 128
/// - inactivity timeout = 15s
/// - request timeout = 15s
pub fn new(id: &ProtocolId) -> Self {
let mut c = Config {
max_data_size: 1024 * 1024,
max_data_size: 64 * 1024 * 1024,
Copy link
Member

@bkchr bkchr Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 64MB not a little too much? Any idea why the request is that big?

I would have assumed that this #5179 brings down the size.

max_pending_requests: 128,
inactivity_timeout: Duration::from_secs(15),
request_timeout: Duration::from_secs(15),
Expand Down