This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move fast benchmarks macro into frame_benchmarking#5445
Merged
shawntabrizi merged 7 commits intogav-fast-benchmarksfrom Mar 31, 2020
Merged
Move fast benchmarks macro into frame_benchmarking#5445shawntabrizi merged 7 commits intogav-fast-benchmarksfrom
frame_benchmarking#5445shawntabrizi merged 7 commits intogav-fast-benchmarksfrom
Conversation
shawntabrizi
requested review from
NikVolf,
gui1117 and
kianenigma
as code owners
gui1117
approved these changes
Mar 31, 2020
gui1117
added
A8-mergeoncegreen
B0-silent
gavofyork
added a commit
that referenced
this pull request
Mar 31, 2020
* Batch benchmarks together with `*` notation. * Fix short structopt conflict * Return error if `batches` is empty * Move fast benchmarks macro into `frame_benchmarking` (#5445) * Move macro into `frame_benchmarking` * Update docs * Extra line * Return error if `batches` is empty Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…aritytech#948) * Use `add_benchmark` macro * Return error if `batches` is empty * Update Cargo.lock * Companion for paritytech#5463 (paritytech#953) * Fix test with genesis block 0 * Update Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This iterates on #5436.
frame_benchmarkingpallet!toadd_benchmark!