check polkadot for companion pull requests #5262
Conversation
gabreal
added
A3-in_progress
.maintain/gitlab/check_polkadot.sh
Outdated
| SUBSTRATE_PATH=$(pwd) | ||
|
|
||
| # Clone the current Polkadot master branch into ./polkadot. | ||
| git clone --depth 1 https://gitlab.parity.io/parity/polkadot.git |
There was a problem hiding this comment.
I didn't change that. It probably won't be faster since the runners do not host the repo. will change to github, thanks.
gabreal
force-pushed
the
general-check-polkadot
branch
from
f041736 to
c855ff4
Compare
gabreal
added
A0-please_review
|
I will remove the companion pr tag (it's just a random pr in the polkadot repo) after approval. |
gabreal
changed the title
.maintain/gitlab/check_polkadot.sh
Outdated
| cargo update | ||
|
|
||
| # Check whether Polkadot pr or master branch builds with this Substrate commit. | ||
| time cargo check |
There was a problem hiding this comment.
I think we should run cargo test.
While this would find compilation problems, it would not find behavior changes.
.maintain/gitlab/check_polkadot.sh
Outdated
| mkdir .cargo | ||
| # echo "paths = [ \"$SUBSTRATE_PATH\" ]" > .cargo/config | ||
| # see https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html | ||
| echo "[patch.\"https://github.com/paritytech/substrate\"]\nsubstrate = { path = \"$SUBSTRATE_PATH\" }" > .cargo/config |
There was a problem hiding this comment.
I don't understand, can you pls explain?
There was a problem hiding this comment.
the ci pipeline is completely green for this branch: https://gitlab.parity.io/parity/substrate/pipelines/84173
(i just pushed a tag along with it before and that's why there are tag jobs that failed)
There was a problem hiding this comment.
I pushed a test commit changing a function that is used in Polkadot and the job executed successfully. This shows that this is not working.
There was a problem hiding this comment.
If it is not too time consuming for you, would you mind explaining why?
There was a problem hiding this comment.
When you want to "patch" a crate, you need to list it. But you are only listing the substrate crate, which is the name of the substrate node. This crate is not even used by Polkadot.
There was a problem hiding this comment.
I see, thanks, code updated resp reverted.
Co-Authored-By: Bastian Köcher <[email protected]>
bkchr
force-pushed
the
general-check-polkadot
branch
2 times, most recently
from
ac86b4d to
c2ce18e
Compare
gabreal
requested review from
NikVolf,
Robbepop,
gui1117,
kianenigma,
mxinden,
pepyakin,
sorpaas and
tomusdrw
as code owners
bkchr
force-pushed
the
general-check-polkadot
branch
from
c2ce18e to
b29a323
Compare
|
@gabreal looks good :) I removed my test commit. |
* check_polkadot: move to external script * check_polkadot: check for companion pr Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
This pr will enable the
check_polkadotci job to check for a companion pr string in the description.polkadot companion: paritytech/polkadot#928