This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client/authority-discovery: Instrument code with Prometheus#5195
Merged
gavofyork merged 5 commits intoparitytech:masterfrom Mar 11, 2020
Merged
client/authority-discovery: Instrument code with Prometheus#5195gavofyork merged 5 commits intoparitytech:masterfrom
gavofyork merged 5 commits intoparitytech:masterfrom
Conversation
Introduce Prometheus metrics into the authority discovery module enabling one to observe: - authority_discovery_times_published_total - authority_discovery_amount_external_addresses_last_published - authority_discovery_times_requested_total - authority_discovery_dht_event_received
expenses
suggested changes
Mar 9, 2020
Contributor
expenses
left a comment
expenses
left a comment
There was a problem hiding this comment.
Generally looks good, metric documentation could be improved a little bit (English 🤷♀️).
expenses
suggested changes
Mar 9, 2020
Co-Authored-By: Ashley <ashley.ruglys@gmail.com>
Contributor
Author
|
Thanks @expenses, appreciated! Can you take another look? |
Co-Authored-By: Ashley <ashley.ruglys@gmail.com>
Member
|
@mxinden tests failing? |
gavofyork
added
A7-looksgoodtestsfail
and removed
A0-please_review
Member
|
@mxinden merging master should fix it. |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 12, 2020
…ch#5195) * client/authority-discovery: Instrument code with Prometheus Introduce Prometheus metrics into the authority discovery module enabling one to observe: - authority_discovery_times_published_total - authority_discovery_amount_external_addresses_last_published - authority_discovery_times_requested_total - authority_discovery_dht_event_received * client/authority-discovery/src/lib.rs: Reword metric help texts Co-Authored-By: Ashley <ashley.ruglys@gmail.com> * client/authority-discovery/src/lib.rs: Reword metric help text Co-Authored-By: Ashley <ashley.ruglys@gmail.com> * client/authority-discovery/tests: Fix struct instantiation + basic test Co-authored-by: Ashley <ashley.ruglys@gmail.com>
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
…ch#5195) * client/authority-discovery: Instrument code with Prometheus Introduce Prometheus metrics into the authority discovery module enabling one to observe: - authority_discovery_times_published_total - authority_discovery_amount_external_addresses_last_published - authority_discovery_times_requested_total - authority_discovery_dht_event_received * client/authority-discovery/src/lib.rs: Reword metric help texts Co-Authored-By: Ashley <ashley.ruglys@gmail.com> * client/authority-discovery/src/lib.rs: Reword metric help text Co-Authored-By: Ashley <ashley.ruglys@gmail.com> * client/authority-discovery/tests: Fix struct instantiation + basic test Co-authored-by: Ashley <ashley.ruglys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Prometheus metrics into the authority discovery module
enabling one to observe:
authority_discovery_times_published_total
authority_discovery_amount_external_addresses_last_published
authority_discovery_times_requested_total
authority_discovery_dht_event_received
This is still missing a corresponding Polkadot pull request given that one now needs to pass a registry to the authority discovery module.Corresponding Polkadot pull request: paritytech/polkadot#893