This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Un-deprecate ValidateUnsigned #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Feb 20, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 4, 2020
* Un-deprecate ValidateUnsigned. * Bump runtime. * Bump runtime. Co-authored-by: Shawn Tabrizi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related paritytech/polkadot-sdk#365 and #3419
Implementing unsigned validation via
SignedExtensionfor a single pallet is a bit cumbersome currently. We're lacking some extra glue code to make it as easy as forValidateUnsigned.Because of this I'd like to propose to un-deprecate
ValidateUnsignedfor 2.0 release and possibly deprecating it only after (but as I said in paritytech/polkadot-sdk#365 I think it may end up useful anyway; I'm currently evaluating that).Submitting this as a minimal PR so that it can later be reverted easily if needed.