This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Cleanup the exports of sc-network #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are a couple of methods that really aren't greatly designed (for example |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Feb 20, 2020
* Cleanup the exports of sc-network * Fix RPC tests * Revert moving the NetworkStateInfo trait * Fix GrandPa tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we stabilize stuff, I thought I'd clean up a bit the API of
sc-network.This PR doesn't do anything except move code around between modules.
Most notably, everything that is only needed during the initialization process (for example the
TransactionPooltrait) has been moved into theconfigmodule.I also moved everything related to
NetworkStateto a separate module.A couple things have been
#[doc(hidden)]'ed rather than removed:ProtocolConfigstruct contains only two fields and is used insc-network-testonly.messagemodule and its content are supposed to be implementation details and really aren't supposed to be exposed. Right now we create and destroyConsensusGossipstructs insc-network-gossip, and we use theBlockDatanetwork message as the format to store blocks in when exporting/importing blocks in the CLI.This PR is expected to go in pair with #4665, which will finish the clean-up.