This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix flaky finalisation test #4967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
force-pushed
the
nv-fix-fork-aware
branch
from
348fe83 to
0efe063
Compare
tomusdrw
approved these changes
Feb 18, 2020
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
lgtm as an immediate remedy, but would be good to figure out what exactly is happening. CC @seunlanlege can we make this test deterministic?
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @seunlanlege
Closes #4944