This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce sign_with method in keystore#4925
Merged
bkchr merged 73 commits intoparitytech:masterfrom Mar 30, 2020
Merged
Conversation
gnunicorn
suggested changes
Feb 14, 2020
bkchr
suggested changes
Feb 14, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
I think it is a good start. However I don't understand the reason for SupportedPublicKey. We decided against using an enum for the crypto types and added explicit functions. I would like to see that we continue with that.
sign_with should return a Future.
This change is being introduced for the purpose of identifying a public key with it's identifier and algorithm "kind".
bkchr
suggested changes
Feb 17, 2020
NikVolf
reviewed
Feb 17, 2020
NikVolf
reviewed
Feb 17, 2020
NikVolf
reviewed
Feb 17, 2020
NikVolf
reviewed
Feb 17, 2020
gnunicorn
added
A3-in_progress
NikVolf
reviewed
Feb 19, 2020
NikVolf
reviewed
Feb 19, 2020
NikVolf
reviewed
Feb 19, 2020
bkchr
approved these changes
Mar 23, 2020
Member
|
Before merging, I would like to test this on one of our Kusama validators. |
gavofyork
added
A8-mergeoncegreen
and removed
A0-please_review
rakanalh
requested review from
Demi-Marie,
Robbepop,
andresilva,
gui1117,
kianenigma and
sorpaas
as code owners
rakanalh
removed request for
Demi-Marie,
Robbepop,
andresilva,
gui1117,
kianenigma,
mxinden,
pepyakin and
sorpaas
Contributor
Author
|
Opps, screwed something up... sorry about that and i'll fix it |
Member
|
Deployed to one validator. |
This was referenced May 7, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort on implementing Remote signing.
The change introduces
sign_withmethod where the caller passes the public key and the key type ID. The pair matching against those parameters is done within the store rather than outside of it so that the call site isn't responsible about signing implementation details.