Re-enable networking on wasm #4880
Conversation
|
Looks good to me (assuming we switch back to a published version before merging) |
| @@ -8,6 +8,9 @@ edition = "2018" | |||
| license = "GPL-3.0" | |||
| default-run = "substrate" | |||
|
|
|||
| [package.metadata.wasm-pack.profile.release] | |||
| wasm-opt = false | |||
There was a problem hiding this comment.
wasm-pack seems to be shipping with a broken wasm-opt. When I build the wasm binary on either the build server or my machine, it maxes out all the cores and doesn't seem to finish. Hopefully this'll get fixed soon.
There was a problem hiding this comment.
Do you have an issue for what you're talking about? Let's link to it to explain the line so that people can remove it in the future
There was a problem hiding this comment.
Nothing specific to this issue, but wasm-pack seems to be having a lot of problems with wasm-opt on linux, rustwasm/wasm-pack#782, rustwasm/wasm-pack#781 and the recent changes don't seem to have improved things.
There was a problem hiding this comment.
Please at least add a comment explaining what this line is for.
|
Sorry, forget to enable timeouts in telemetry too. |
|
a fix has been merged on master. please update to latest master and lets try again. |
* Use noise and timeouts on wasm * Don't use wasm-opt when compiling to wasm * Forgot lockfile * Add node about disabling wasm-opt * Enable timeouts in telemetry on wasm
Waiting for a new version of libp2p to be published that contains libp2p/rust-libp2p#1439.