This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pow: re-add support for algorithms where only linear verification is possible#4843
Merged
pow: re-add support for algorithms where only linear verification is possible#4843
Conversation
NikVolf
reviewed
Feb 6, 2020
| sp_consensus::Error | ||
| > where | ||
| B: BlockT, | ||
| C: ProvideRuntimeApi<B> + HeaderBackend<B> + BlockOf + ProvideCache<B> + AuxStore, |
Contributor
There was a problem hiding this comment.
I wonder how many of those generic bounds never get deleted elsewhere
bkchr
approved these changes
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the API of PoW engine after #4652. No-parent verification now again becomes optional (called
preliminary_verify). This is needed because for some algorithms only linear verification is possible (for PoW algorithms that just relies on parent block information). Also fixed some unused generic parameters.