This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactor epoch changes to a separate crate#4785
Merged
Conversation
sorpaas
commented
Jan 31, 2020
| #[cfg(feature = "std")] | ||
| #[derive(Clone, Debug)] | ||
| pub enum BabePreDigest { | ||
| pub enum PreDigest { |
Contributor
Author
There was a problem hiding this comment.
There are some naming changes. This is opinioned, but the rationale is that:
digestmod is renamed todigests. This is to keep it consistent withinherentsmod.BabePreDigestis renamed toPreDigest. We usually only use one engine at a time, and thus it is not common to have naming collisions of multiplePreDigest. Plus, it keeps it consistent withNextEpochDescriptor.
It unfortunately won't work for multiple crates.
andresilva
previously requested changes
Feb 5, 2020
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
changes lgtm, but babe is failing to compile due to diverging parking_lot types.
Contributor
Author
|
@andresilva Can you take another look? |
rphmeier
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Split off from #4600)
This refactors
EpochChangesto be in a separate crate, so that it can be reused in other engines, such as Sassafras.