This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fork-tree: add support for find_node_mut_where#4784
Merged
Conversation
bkchr
reviewed
Jan 31, 2020
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
rphmeier
reviewed
Jan 31, 2020
| // an iterative definition instead. | ||
| pub fn find_node_where<F, P, E>( | ||
| /// | ||
| /// The returned indexes are from last to first, meaning the last is the least significant |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The returned indexes are from last to first, meaning the last is the least significant | |
| /// The returned indices are from last to first, meaning the last is the least significant |
Contributor
There was a problem hiding this comment.
it's not clear what "least significant" means in this comment, but from reading the code i take it to be the earlier index in the traversal path.
Contributor
Author
There was a problem hiding this comment.
I updated the docs just calling it the "earliest" and "final" index.
Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>
rphmeier
approved these changes
Feb 1, 2020
rphmeier
added
A8-looksgood
and removed
A0-please_review
Contributor
|
Thank you Wei! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Split out of #4600, for easier review/merge.)
This adds support to get mutable references of
Nodein aForkTree, by using a helper methodfind_node_index_wherethat returns the indexes to access the node. Mutable reference is needed for consensus such as Sassafras, because we need to push VRF proofs after the epoch data is created.