This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client/finality-grandpa/src/observer: Poll NetworkBridge#4766
Merged
gavofyork merged 1 commit intoparitytech:masterfrom Jan 29, 2020
Merged
client/finality-grandpa/src/observer: Poll NetworkBridge#4766gavofyork merged 1 commit intoparitytech:masterfrom
gavofyork merged 1 commit intoparitytech:masterfrom
Conversation
Patch d4fbb89 reintegrated the periodic neighbor packet worker, by moving its logic into a `Future` implementation on `NetworkBridge` which needs to be polled by its upper layer. Polling by the upper layer was implemented within the `Future` implementation of the `VoterWork` struct but not within the `Future` implementation of the `ObserverWork` struct. This patch adds polling of the `NetworkBridge` to the latter.
andresilva
approved these changes
Jan 29, 2020
tomaka
approved these changes
Jan 29, 2020
NikVolf
reviewed
Jan 29, 2020
Contributor
NikVolf
left a comment
NikVolf
left a comment
There was a problem hiding this comment.
Issue for the regression test for this? :)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch d4fbb89 reintegrated the periodic neighbor packet worker, by
moving its logic into a
Futureimplementation onNetworkBridgewhichneeds to be polled by its upper layer.
Polling by the upper layer was implemented within the
Futureimplementation of the
VoterWorkstruct but not within theFutureimplementation of the
ObserverWorkstruct. This patch adds polling ofthe
NetworkBridgeto the latter.Without this bugfix nodes running as a Grandpa Observer don't report
reputation changes to the underlying network and don't send neighbor
packets.