This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove now unused lang_items feature in IO primitives
#4596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @Xanewok signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Contributor
Author
|
This is based on latest master now, I believe #4597 should fix the breakage there once it's merged |
Member
|
It is merged now :) |
We don't use any explicit `#[lang = ...]` items anymore (`panic_fmt` is replaced with now-stable `#[panic_implementation]`, OOM is handled via `alloc_error_handler` directly etc.), so I thought it'd be good to remove it for clarity to limit used nightly features.
Xanewok
force-pushed
the
no-lang-items
branch
from
3bab811 to
e23d5ce
Compare
Contributor
Author
|
Thanks, rebased just now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a drive-by fix as I'm slowly digging into the code.
We don't use any explicit
#[lang = ...]items anymore (panic_fmtis replaced with now-stable#[panic_implementation], OOM is handled viaalloc_error_handlerfeature directly etc.), so I thought it'd be good to remove it for clarity to limit used nightly features.