Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@arkpar
Copy link
Member

@arkpar arkpar commented Jan 7, 2020

Fixed a couple of potential soundness issues with pinned states in states in state-db

  • Pinned state would not pin parent state, so it could still be discarded
  • Pinned state nodes still could be discarded if they had more than one references and only one of the referencing states is pinned.

Fixes paritytech/polkadot#705

@arkpar arkpar added the A0-please_review Pull request needs code review. label Jan 7, 2020
@svyatonik svyatonik added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jan 11, 2020
@gavofyork gavofyork merged commit 8be0d69 into master Jan 13, 2020
@gavofyork gavofyork deleted the a-fix-db branch January 13, 2020 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thread 'txpool-verifier1' panicked at 'Externalities not allowed to fail within runtime

4 participants