This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Clean-ups in the network-gossip crate #4542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Successfully tested on Kusama. |
Contributor
Author
|
Polkadot PR: paritytech/polkadot#732 |
rphmeier
reviewed
Jan 7, 2020
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Substrate. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
rphmeier
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs a few clean-ups related to the
sc-network-gossipcrate:sc_network::Context, and directly pass a&mut dyn Networkinstead.sc_network::Contextanymore, removes theContext::send_consensusmethod. TheContextis now used exclusively for theNetworkSpecializationstuff, which is hopefully going to disappear in the future as well.Validatortrait and its related traits and structs to a separate module.