Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gabreal
Copy link
Contributor

@gabreal gabreal commented Dec 23, 2019

CI jobs are failing due to recently introduced shallow clones for ci checks e.g. https://gitlab.parity.io/parity/substrate/-/jobs/333878

Increasing the cloning depth to 100 should be a safe value 🤞

failing refs in local copy:

fatal: ambiguous argument 'origin/master...2003b9d8a08c9b9370a94cb0ee3c0f3e05607ce6': unknown revision or path not in the working tree.

@bkchr
Copy link
Member

bkchr commented Dec 23, 2019

We still get:
fatal: ambiguous argument 'origin/master...0ee1bc18a94be7fa73258c8b3d674ad428ab9302': unknown revision or path not in the working tree.

Could you please also update check-runtime to fail properly as well. It should not succeed when it does not work (as it is currently).

@gabreal
Copy link
Contributor Author

gabreal commented Dec 23, 2019

@bkchr which pull request was that?

@bkchr
Copy link
Member

bkchr commented Dec 23, 2019

This one^^

@bkchr bkchr merged commit 73ae66a into master Dec 23, 2019
@bkchr bkchr deleted the ci-adjust-git-depth branch December 23, 2019 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants