-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add a browser-utils crate
#4394
Conversation
222ce99 to
e73aac3
Compare
gnunicorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some minor things, aside from that I don't have any complaints. But I don't know this code or what it should be doing well enough to judge this at all. Inviting @tomaka to take a look instead.
Co-Authored-By: Benjamin Kampmann <[email protected]>
…e into ashley-browser-utils
| #!/usr/bin/env sh | ||
| wasm-pack build --target web --out-dir ./browser-demo/pkg --no-typescript --release ./.. -- --no-default-features --features "browser" | ||
| python -m SimpleHTTPServer 8000 | ||
| python -m http.server 8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Python2 is now deprecated 😅
|
IMO we should be more explicit in the What this PR does is okay-ish but doesn't go in the direction of having clean code. We can either merge now and fix later, or improve this PR itself. |
|
@tomaka What can be cleaned up? |
|
What I mentioned: not having platform-specific code in the |
client/service/src/builder.rs
Outdated
| } | ||
|
|
||
| /// Full client type. | ||
| pub type TFullClient<TBl, TRtApi, TExecDisp> = Client< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the next obvious step is to adjust config.keystore_path to be an enum of either a path or "in memory".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tomaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Obviously path being an Option is also not great, but I'm not going to ask you to entirely refactor Substrate in this PR.
|
This needs a Polkadot PR because of the change in the configuration now though. |
|
tests not passing either |
|
Needs resolving. |
|
Not sure what's causing |
There is a lot of shared logic between the test substrate/polkadot in-browser light clients I've been working on, so I'm putting it in this
browser-utilscrate.For clarity: I'm still working out how to best approach certain changes needed to get the light clients to work properly, so I'm merging things piece-by-piece.