This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Recover light client integration tests #4377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
reviewed
Dec 12, 2019
| } else { | ||
| NUM_FULL_NODES | ||
| }; | ||
| let expected_light_connections = NUM_FULL_NODES; |
Contributor
There was a problem hiding this comment.
Should this be NUM_LIGHT_NODES?
Contributor
Author
There was a problem hiding this comment.
It is a number of connections at light nodes. Light nodes only connect to full nodes => NUM_FULL_NODES.
HCastano
approved these changes
Dec 12, 2019
Contributor
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
I'm not entirely clear about the context behind the removal and now restoration of the LC integration tests, so maybe somebody else should chime in with regards to that. Code itself looks fine though.
gavofyork
added
A7-looksgoodcantmerge
and removed
A0-please_review
bkchr
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been sure that BABE' light client is broken since #3583 , because it has been removed from tests there + I've seen no consensus cache usage in the code. This was until this morning, when I've noticed that the full client now also doesn't call runtime for anything else than configuration at genesis block. Since this (runtime calls) was the only reason that light client was requiring additional care (storing epoch data in the consensus cache), there's no other reasons why light client should not work.
So I'm restoring integration tests for LC in this PR.