This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fixed node binary #4244
Merged
Fixed node binary #4244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcio-diaz
approved these changes
Nov 28, 2019
bkchr
suggested changes
Nov 28, 2019
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
The linked pr not only introduced this double "execution" cli parameter, purge-chain for example now also has all of these parameters that make no sense for purge chain. Please fix this as well. The best would probably to introduce a SharedExecutionParams or whatever that holds all the stuff that is shared between commands that execute something.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4240 substrate binary ended up having duplicate "execution" args.