Use raw public key instead of compressed

[fubuloubu]

Fixes: #4216

[parity-cla-bot]

It looks like @fubuloubu signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[bkchr]

Whitespaces

[fubuloubu]

Also, as noted in #4216 (comment) using keccak256 instead of blake2_256 in AccountId hashing logic would make this more Ethereum-compatible, but as I noted in my response it would be better if AccountId wasn't assumed 32 bytes (instead just Sized) and was user configurable with how addresses are encoded.

I could add keccak_256 to this PR though.

[gavofyork]

AccountId is:

type AccountId: Parameter + Member + MaybeSerializeDeserialize + Debug + MaybeDisplay + Ord + Default;

So basically, you can have it be any type you want. There's no need for this PR, though since it doesn't really break anything and makes things strictly more compatible I'm ok merging it. But you can in any case make a 20-byte AccountId and use sha256, keccak256, ripemd-160 or whatever else if you really want and you can make a new Signature type which is compatible with it (and a new MultiSignature if you want to support other crypto at the same time, too). That's the beauty of FRAME - it provides the abstractions to let you decide without needing the code to be in the core.

[gavofyork]

For now, though, some of the CI is failing and will need to be fixed before it can be merged.

[fubuloubu]

[Y]ou can in any case make a 20-byte AccountId and use sha256, keccak256, ripemd-160 or whatever else if you really want and you can make a new Signature type which is compatible with it (and a new MultiSignature if you want to support other crypto at the same time, too).

Ah, well I will have to try a different method of doing what I want. I was using MultiSigner and MultiSignature, which builds in that presumption of the blake2 hash, and I assumed there was no other way to do it, but I see where I am wrong though. This PR is definitely still foundational however.

Will fix CI issues.

[fubuloubu]

As noted above, the 120 char line limit is failing because I made a hex string larger. It doesn't seem like I should be splitting it up, so it is probably best to ignore this error?

The other two errors do not seem to be my fault, as far as I can tell.

Please advise.