This repository was archived by the owner on Nov 15, 2023. It is now read-only.
The crate rename #4223
Merged
The crate rename #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
requested review from
Demi-Marie,
Robbepop,
andresilva,
gui1117,
jimpo,
kianenigma and
pepyakin
as code owners
gnunicorn
force-pushed
the
ben-the-crate-rename
branch
from
5b3afac to
e29ff6f
Compare
gnunicorn
force-pushed
the
ben-the-crate-rename
branch
from
e29ff6f to
e86d69a
Compare
Contributor
Author
|
force pushed a new run of the script against master (rather than attempting to fix the enormous conflict) |
gnunicorn
force-pushed
the
ben-the-crate-rename
branch
2 times, most recently
from
32ef1c3 to
985ba76
Compare
gnunicorn
force-pushed
the
ben-the-crate-rename
branch
from
985ba76 to
6f77e0a
Compare
tomusdrw
approved these changes
Dec 2, 2019
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
lgtm as is. I mostly focused my review on the script, as I suspect the rest is just the script being applied.
Merged
sorpaas
pushed a commit
that referenced
this pull request
Nov 20, 2020
* Adding script for rename, could be applicable for nodes on top of it, too * add stderr and gitlab ci features * apply script * fix now minor details in expected stderr * Update the Cargo.lock * fix name: sc-transaction -> sc-tracing * fix rename in script, too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #4099 .
Rename crates in
/primitivesand/client: prefix them with withsp-andsc-respectively, remove any unnecessary suffixing-primitives,-runtime-api. Fixup all the used names inside the repo.Upgrading
You'll find the bash script
rename-crates-for-2.0.shin the.maintain-folder. It is the script that was run and should be working the same way on your substrate-github-referencing project by renaming all the references inCargo.tomland*.rs-files. You might have tocargo cleanand build on a clean project again, if you encounter errors.