This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Grandpa: save all completed prior rounds #4203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcio-diaz
added
the
A3-in_progress
marcio-diaz
added
A0-please_review
marcio-diaz
changed the title
Member
|
Does this fix paritytech/polkadot-sdk#93? |
Contributor
Author
I think it can be extended for that. It was initiated by this comment of @rphmeier : "About the database: at the moment we only persist some small amount of completed rounds. one thing we need to do soon is get a DB where we have all prior completed rounds' data. This should also help with addressing any relevant issues" |
Member
|
@rphmeier does this do what you suggested? |
rphmeier
approved these changes
Nov 29, 2019
Contributor
rphmeier
left a comment
rphmeier
left a comment
There was a problem hiding this comment.
might lean a bit too heavily on the existing CompletedRounds structure storing the stuff which isn't concluded yet, but workable.
marcio-diaz
commented
Nov 29, 2019
Member
|
@marcio-diaz CI fails. |
…aritytech/substrate into marcio/save-all-prior-completed-rounds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves all concluded rounds into DB.
TODO:
complete().