This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Check in block authoring that we can author with current authoring version #4201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
requested review from
Demi-Marie,
andresilva,
pepyakin and
tomusdrw
as code owners
andresilva
approved these changes
Nov 27, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
lgtm. we should think about exposing this through some RPC so that validators can easily monitor it.
Member
|
@arkpar : didn't already implement this 18 months ago? :-) |
gavofyork
added
A7-looksgoodtestsfail
and removed
A0-please_review
Member
|
I did here: https://github.com/paritytech/substrate/pull/256/files#diff-76964ec8de481638ce29d022262cfc53R454 |
Member
|
CI fails. |
bkchr
force-pushed
the
bkchr-can-author-with
branch
from
fbd4426 to
abc715e
Compare
Member
|
@bkchr will need a polkadot PR... |
Member
Author
|
Yeah, just waiting for #4236 and than will open a pr for both :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that we can still author with the current block authoring implementation, because there could have been a runtime update in between that made the current implementation incompatible.