This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Society pallet #4170
Merged
Society pallet #4170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
the
A3-in_progress
niklasad1
reviewed
Dec 8, 2019
…ed-id # Conflicts: # frame/identity/src/lib.rs
…ed-id # Conflicts: # frame/identity/src/lib.rs
gavofyork
commented
Dec 14, 2019
gavofyork
commented
Jan 4, 2020
gavofyork
commented
Jan 4, 2020
gavofyork
commented
Jan 4, 2020
gavofyork
commented
Jan 4, 2020
gavofyork
commented
Jan 4, 2020
Member
Author
gavofyork
left a comment
gavofyork
left a comment
There was a problem hiding this comment.
Some work needed, but added logic seems broadly correct.
If no one at all votes, or the vote is tied, the user will be suspended from society. This means, that the user simply needs to vote for themselves to stay in society assuming no one else participates.
shawntabrizi
reviewed
Jan 7, 2020
Comment on lines
+72
to
+78
| //! #### Rate of Growth | ||
| //! | ||
| //! The membership society can grow at a rate of 10 accepted candidates per rotation period up | ||
| //! to the max membership threshold. Once this threshold is met, candidate selections | ||
| //! are stalled until there is space for new members to join. This can be resolved by | ||
| //! voting out existing members through the random challenges or by using governance | ||
| //! to increase the maximum membership count. |
Member
There was a problem hiding this comment.
Note the behavior when max membership is reached.
It is possible that we have max_membership + 10 total users in the member list. This is because the approved candidates have no clean way to "fail" when being added to the membership list.
The scenario can happen as so:
- There are 90 active members in society
- There are at least 10 suspended members in society
- There are 10 approved candidates that will make it in during the next rotation period
- The suspension judgement origin adds 10 suspended members back to the society, reaching the limit of 100
- Then the rotation period occurs and 10 candidates are added on top
As mentioned with inline comments, this has no consensus critical issue or side effects. Being over the max or being at the max is exactly the same behavior.
shawntabrizi
reviewed
Jan 7, 2020
shawntabrizi
approved these changes
Jan 7, 2020
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
I think it is ready to be played with :)
gavofyork
commented
Jan 10, 2020
gavofyork
commented
Jan 10, 2020
gavofyork
commented
Jan 10, 2020
Member
Author
|
A few blank lines in there, I'll take a more in-depth look at the changed logic tomorrow. |
Member
Author
|
CI failure unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Society is basically a membership provider where member-candidates are voted in by existing members. Candidacy/entrance requirements can be put in place, as well as ongoing random verification requirements. A suspension & appeals process exists for when candidates/members fail to make or retain the approval of the membership.
TODO: