Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

General multiplexing fixes #408

Merged
gavofyork merged 1 commit into from
Jul 23, 2018
Merged

General multiplexing fixes #408

gavofyork merged 1 commit into from
Jul 23, 2018

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 23, 2018

Integrates PRs libp2p/rust-libp2p#355 and libp2p/rust-libp2p#360

This fixes the follwing:

  • We would open multiple TCP connections for multiple substreams if they didn't open quick enough (ie. based on the order in which futures were processed).
  • Even if all substreams to a remote were closed (as was the case when a ping fails for example), the code would continue to assume that the TCP connection was alive and would try use it for new substreams.
  • Mplex substreams would never close, even when closed by the remote.

The network should be much more reliable with this change.

@tomaka tomaka added A0-please_review Pull request needs code review. M4-core labels Jul 23, 2018
@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Jul 23, 2018
@gavofyork gavofyork merged commit ef72255 into paritytech:master Jul 23, 2018
@tomaka tomaka deleted the multiplexing branch July 23, 2018 14:08
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
@liuchengxu
Fix staking locked balance can be more than the free balance (parityt…
4a5f11f 
…ech#408)

* Fix staking locked balance are more than the free balance

* Only remove unlockings in purge_unlockings()

* .

* .

* Bump spec version
liuchengxu added a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
@liuchengxu
Merge pull request paritytech#408 from subspace/check-execution-recei…
e6b3f3b 
…pt-signature-on-farmer

Check the signature and signer of execution receipt on farmer
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
@jsdw
Allow decoding Events containing BitVecs (paritytech#408)
d1494b5 
* Handle bitvec decoding

* clippy

* rework bitvec decoding; don't care about order and can handle other store primitives

* cargo fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arkpar arkpar arkpar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaka @arkpar @gavofyork