This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client canonical key value storage #4003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complete some test method by providing child access to values.
is. Need to use historied values, maybe remove pinned, and put some context as parameter for get_offstate
probably need to store state, apply gc on state and depending on result restore state or actually gc historied values.
should get updated.
for gc. Need to change commit set to contain an history of values and adjust test db.
integrated into storage cache (no handling of kv there yet).
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>
Break big line.
Contributor
Author
|
Closing this PR because Child trie associated issue will be work around in a way that does not require this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract the client and client-db logic from #3774 to try to make it more reviewable.
For general goal of key value storage, please refer to #3774.
As an extract from #3774, some TODO are present on state machine and state-db interfaces and tests are not functional.
Serializedsequential history of canonical key values.History serialization is defined in historical-data crate.
This means that archive all mode is limited to canonical blocks (implementation of archive all seems doable but change the backend storage logic to use a branch indexing).
StorageAt) at a targeted block (last canonical block). A typical query involve querying the statedb first, followed by the canonical client storage.