Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@HCastano
Copy link
Contributor

No description provided.

@HCastano HCastano added the A0-please_review Pull request needs code review. label Oct 25, 2019
@HCastano HCastano requested a review from jimpo October 25, 2019 10:25
@parity-cla-bot
Copy link

It looks like @HCastano signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

Copy link
Contributor

@jimpo jimpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good.

@HCastano HCastano requested a review from jimpo October 31, 2019 15:34
@HCastano HCastano merged commit 212a907 into paritytech:hc-jp-bridge-module Nov 1, 2019
@HCastano HCastano deleted the hc-validate-validator-set branch November 1, 2019 14:42
HCastano added a commit to HCastano/substrate that referenced this pull request Nov 11, 2019
…ytech#3915)

* Make StorageProofChecker happy

* Update some tests

* Check given validator set against set found in storage

* Use Finality Grandpa's Authority Id and Weight

* Add better error handling

* Use error type from decl_error! macro
HCastano added a commit that referenced this pull request Dec 12, 2019
* Make StorageProofChecker happy

* Update some tests

* Check given validator set against set found in storage

* Use Finality Grandpa's Authority Id and Weight

* Add better error handling

* Use error type from decl_error! macro
HCastano added a commit that referenced this pull request Jan 10, 2020
* Make StorageProofChecker happy

* Update some tests

* Check given validator set against set found in storage

* Use Finality Grandpa's Authority Id and Weight

* Add better error handling

* Use error type from decl_error! macro
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants