Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Dry out Author RPC tests a bit#3878

Merged
gavofyork merged 1 commit intomasterfrom
nv-rpc-test-dry
Oct 22, 2019
Merged

Dry out Author RPC tests a bit#3878
gavofyork merged 1 commit intomasterfrom
nv-rpc-test-dry

Conversation

@NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Oct 22, 2019

No description provided.

@NikVolf NikVolf requested a review from tomusdrw as a code owner October 22, 2019 11:13
@parity-cla-bot
Copy link

It looks like @NikVolf signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@NikVolf NikVolf closed this Oct 22, 2019
@NikVolf NikVolf reopened this Oct 22, 2019
@NikVolf
Copy link
Contributor Author

NikVolf commented Oct 22, 2019

Can anybody restart the build job?

@NikVolf NikVolf added the A0-please_review Pull request needs code review. label Oct 22, 2019
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

}
}

fn setup() -> TestSetup {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe TestSetup::default or TestSetup::new to keep everything in a single place?

@tomusdrw tomusdrw added A8-looksgood and removed A0-please_review Pull request needs code review. labels Oct 22, 2019
@gavofyork gavofyork merged commit b9d6663 into master Oct 22, 2019
@gavofyork gavofyork deleted the nv-rpc-test-dry branch October 22, 2019 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants