This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make tests work after the changes introduced in #3793 #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
added
A0-please_review
|
It looks like @HCastano signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
bkchr
reviewed
Oct 22, 2019
andresilva
reviewed
Oct 22, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
lgtm other than the unnecessary dependency. but why didn't you push this directly to your branch?
Contributor
Author
I wanted to ping Jim about this without DM-ing him about the changes. |
HCastano
added a commit
to HCastano/substrate
that referenced
this pull request
Nov 11, 2019
…tytech#3874) * Make tests work after the changes introduced in paritytech#3793 * Remove unneccessary import
HCastano
added a commit
that referenced
this pull request
Dec 12, 2019
HCastano
added a commit
that referenced
this pull request
Jan 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.